ci-3692 inset vertical videos#176
Conversation
adgad
left a comment
adgad
left a comment
There was a problem hiding this comment.
happy to approve, am assuming someone in @Financial-Times/spark-team knows about the work needed there!
There was a problem hiding this comment.
The PR looks okay but there is a slight problem which it would introduce to one of the transformer libraries.
Take a look at
func toValidClipLayoutWidth(w string) layoutwidth {
switch w {
case "in-line", "full-grid", "mid-grid":
return layoutwidth(w)
default:
return "in-line"
}
}
This has to be updated to feature the new values. Furthermore, we might need to add these two values here too, if there is the possibility to embed ClipSets in Articles with XML and use these values:
https://github.com/Financial-Times/body-validation-service/blob/f8afabf2a3bfe53c47622d4686770b78787bad50/src/main/resources/xsd/ft-types.xsd#L69
leannecornish-ft
force-pushed
the
ci-3692-inset-video
branch
from
6157096 to
860687c
Compare
I think there may be a possibility of it being used with XML, depending on how quickly the work is done on your side. |
4 participants
So that vertical videos can be inset to the left or right, this PR adds "inset-left" | "inset-right" to
ClipSetLayoutWidthticket: https://financialtimes.atlassian.net/browse/CI-3692